Show git commit and build time in vintner version

Uses Go's automatic VCS build-info stamping (vcs.revision/vcs.time/
vcs.modified, embedded by `go build` since Go 1.18 - no -ldflags
changes needed, works the same for a CI release build and a plain
local `go build`). Knowing the exact commit a bug report's binary was
built from, not just the X.Y.Z tag, is the point - two builds of the
same tag could still differ.

Split the pure formatting logic (formatVersion) from the
debug.ReadBuildInfo() call so it's actually unit-testable: `go test`
binaries don't get VCS stamping the way `go build` ones do, so there
was no way to exercise the revision-formatting branch through
versionString() itself.
This commit is contained in:
Cheviiot
2026-07-25 11:37:02 +10:00
parent 6186837fd2
commit 94a19e6b43
3 changed files with 103 additions and 1 deletions
+46
View File
@@ -0,0 +1,46 @@
package main
import "testing"
func TestFormatVersion(t *testing.T) {
for _, tc := range []struct {
name string
ver, revision, buildTime string
dirty bool
want string
}{
{
name: "no VCS info at all",
ver: "dev",
want: "vintner dev",
},
{
name: "clean build with full info",
ver: "0.3.0",
revision: "6186837fd23616335ba8aff830801692a756799c",
buildTime: "2026-07-25T01:33:41Z",
want: "vintner 0.3.0 (6186837fd236, 2026-07-25T01:33:41Z)",
},
{
name: "dirty tree",
ver: "0.3.0",
revision: "6186837fd23616335ba8aff830801692a756799c",
dirty: true,
want: "vintner 0.3.0 (6186837fd236-dirty)",
},
{
name: "short revision left untouched",
ver: "dev",
revision: "abc123",
want: "vintner dev (abc123)",
},
} {
t.Run(tc.name, func(t *testing.T) {
got := formatVersion(tc.ver, tc.revision, tc.buildTime, tc.dirty)
if got != tc.want {
t.Errorf("formatVersion(%q, %q, %q, %v) = %q, want %q",
tc.ver, tc.revision, tc.buildTime, tc.dirty, got, tc.want)
}
})
}
}